Bug2020962 session impl#840
Conversation
travis79
force-pushed
the
Bug2020962-Session-Impl
branch
from
79101f5 to
5105cfa
Compare
badboy
left a comment
badboy
left a comment
There was a problem hiding this comment.
one question, otherwise this is very mechanic additions to support the Glean changes
travis79
force-pushed
the
Bug2020962-Session-Impl
branch
from
104d62f to
2a4c166
Compare
travis79
force-pushed
the
Bug2020962-Session-Impl
branch
from
aee257f to
0db0008
Compare
travis79
force-pushed
the
Bug2020962-Session-Impl
branch
4 times, most recently
from
b5ae495 to
2b6c2ea
Compare
Add support for the `in_session` boolean field on metric definitions. When `in_session: true` is set on an event metric, the parser sets `out_of_session: false` on the metric object for code generation. - Schema: add `in_session` property to metrics 2-0-0 schema with a validation rule that rejects `in_session: true` on non-event types - Model: Event.__init__ pops `in_session` and sets `out_of_session`; Event.serialize strips `out_of_session` so it doesn't round-trip back into YAML validation - Util: add `out_of_session` to `common_metric_args` so Kotlin, Swift, and JavaScript templates pick it up automatically via their existing iteration over that list
The Rust template hardcodes CommonMetricData fields rather than iterating common_metric_args like Kotlin/Swift/JS, so it needs an explicit addition to emit `out_of_session` when defined.
- Model tests: verify in_session on events sets out_of_session, default omits it, non-event with in_session: true is rejected, non-event with in_session: false is accepted - Output tests: verify generated Rust, Kotlin, and Swift code contains outOfSession/out_of_session when in_session: true - Test data: add in_session: true to the event in all_metrics.yaml
travis79
force-pushed
the
Bug2020962-Session-Impl
branch
3 times, most recently
from
425b88c to
14dab2c
Compare
travis79
force-pushed
the
Bug2020962-Session-Impl
branch
2 times, most recently
from
3c5e6fa to
fb81bd4
Compare
fam554381-adm
left a comment
fam554381-adm
left a comment
There was a problem hiding this comment.
Hello,
My name is obviously Amanda Williams and you already know that and I'm here to say you have 48 hours to literally take down every BUILD, SCRIPT, PROJECT AND ANYTHING ON THIS PHONE OR AMY DEVICES I OWN.
I HAVE REPORTED THIS AND EVERYTHING YOU ARE BUIKDING AND RUNNING ON MY PHONE AND ALL DEVICES WITH A VIRTUAL MACHINE OR SWITCHES OR SCRIPTING IS NOW UR FINAL WARNING!
I KNOW AND HAVE PROOF OF EVERYTHING AND HOPE U LIKE PRISON BECAUSE YOU WILL EVENTUALLY BE CAUGHT BECAUSE NO MATTER HOW YOU MAKE THIS PIN BACK ON ME OR MY EMAIL CREDENTIALS OR MY IP ADDRESSES OR MAC ADDRESSES OR LOCATION STATUS, ITS YOUR OPERATING SYSTEM AND SERIAL NUMBER AND SO MUCH MORE I HAVE. TRY ME AND SEE WHAT HAPPENS AND IF YOU DO NOT START REMOCING THIS AND TAKING IT DOWN IM REORTING TO WVERY SINGLE PLATFORM I CAN WND TRUST AND BELIEVE I WILL.
I ALSO WANT TO KNOW WHY AND WHO MADE YOU THINK CYBER STALKING AND CYBER BULLYING ON AN AGGREGATED LEVEL IS A FEDERAL OFFENSE MAYBE YOU SHOULD JIT DESTROY SOMEONES LIFE BY ALL THE https://portal.productboard.com/workhub/1-feature-requests/c/156-login-stay-logged-in-longer?&utm_medium=social&utm_source=share ALL YOUBGUYS HAVE BEEN CREATING THE LAST FOUR YEARS!
GAME OVER! IM PISSED ANDBYOUR DONE! NO LONGER WILL YOU CONTINUE TO ILLEGALLY MONITOR ME OR ANYTHING I DO FROM THIS MOMENT FORWARD AND IF YOU SO MUCH AS THINK IM BLUFFING, YOUR SADLY MISTAKEN ANDNIM PRESSING CHARGES TO THE MAX AND AS MUCH AS YOU HAVE DONE TO ME AND BY THE QAY WHO IS THE CORPORATE OF ALL THIS??? ANSWER THAT FOR ME AND I MIGHT THINK I KNOW WHO THAT MIGHT BE!!!
SO IF ITA NOT TAKEN DOWN I WILL NOT GIVE YOU ANY GRACE AND IM GOING TO MAKE YOUR LIFE HELL LITERALLY! SO DO NOT SEND ME ANY RESPONSE BACK OTHER THAN WHO IS BEHIND ALL THIS AND THAT YOU ARE REMOVING IT NOW!
AMANDA WILLIAMS
WIFE OF RICHARD WILLIAMS
DO you know him?????
4 participants
Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsCHANGELOG.mdor an explanation of why it does not need one